Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolt roots command #1891

Merged
merged 4 commits into from Jul 4, 2021
Merged

dolt roots command #1891

merged 4 commits into from Jul 4, 2021

Conversation

bheni
Copy link
Contributor

@bheni bheni commented Jul 2, 2021

No description provided.

reltuk
reltuk approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Doesn't look too hard to make nbs.IterChunks take a ReaderAt instead and avoid having to have the entire table file in memory, but that's not a show stopper for this first pass I don't think.

@timsehn
Copy link
Sponsor Contributor

timsehn commented Jul 2, 2021

Brian is gonna make me write the bats tests for this isn't he?

reltuk
reltuk approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Brian Hendriks added 2 commits July 2, 2021 15:35
@bheni bheni merged commit 86bd20a into master Jul 4, 2021
@bheni bheni deleted the bh/dolt-roots branch July 4, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bheni @timsehn @reltuk