No-op bad alter table auto increment #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // In the case that someone runs an alter table auto increment on a table with no existing auto increment key, nop | ||
| if te.autoIncCol.TypeInfo == nil { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
we should no-op in the SQL engine, before we get here
Comment on lines
153
to
155
| // In the case that the alter table is adding a new auto increment value, then it will return a | ||
| // ErrorNoAutoIncrement value. We can ignore that. | ||
| if err != nil && !errors.Is(err, doltdb.ErrNoAutoIncrementValue) { |
There was a problem hiding this comment.
inspect the old/new schemas and catch the case where auto_increment has been added to a column
andy-wm-arthur
approved these changes
Jul 21, 2021
| @@ -147,7 +147,7 @@ func updateTableWithModifiedColumn(ctx context.Context, tbl *doltdb.Table, oldSc | |||
| return nil, err | |||
| } | |||
| var autoVal types.Value | |||
| if schema.HasAutoIncrement(newSch) { | |||
| if schema.HasAutoIncrement(newSch) && schema.HasAutoIncrement(oldSch) { | |||
There was a problem hiding this comment.
this looks much better, could you add a comment explaining the alter table case? Also, what happens if the AUTO_INCREMENT is removed from the schema?
There was a problem hiding this comment.
The new schema would not have auto increment an a nil value would be passed for autoVal
|
Change the Title from "Nop" to "No-op" please |
VinaiRachakonda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pr does 2 things