Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed logging format to take advantage of logger changes in gms #2080

Merged
merged 7 commits into from Sep 2, 2021

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Aug 31, 2021

New log message format sample:

2021-08-31T12:04:36-07:00 DEBUG [conn 1] Starting query {connectTime=2021-08-31T12:04:36-07:00, query=SHOW VARIABLES LIKE 't%_isolation'}

Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1052,7 +1050,7 @@ func (sess *Session) AddDB(ctx *sql.Context, dbState InitialDbState) error {
if dbState.WorkingSet != nil {
sessionState.WorkingSet = dbState.WorkingSet
workingRoot := dbState.WorkingSet.WorkingRoot()
logrus.Tracef("working root intialized to %s", workingRoot.DebugString(ctx, false))
// logrus.Tracef("working root intialized to %s", workingRoot.DebugString(ctx, false))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather delete but nbd

@zachmu zachmu merged commit 9bb89cb into master Sep 2, 2021
@Hydrocharged Hydrocharged deleted the zachmu/logging branch December 8, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants