First Iteration of Application Server Deploy Script #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Nov 2, 2021
docs/deploy-server.sh
Outdated
| setup_configs() { | ||
| # Set up the dolt user along with core dolt configurations | ||
| echo "Setting up Configurations..." | ||
| useradd -r -m -d /var/lib/doltdb dolt |
There was a problem hiding this comment.
Want to check if this user exists first, err if so
There was a problem hiding this comment.
Should we make this configurable? Might be annoying if someone runs the script multiple times/.
docs/deploy-server.sh
Outdated
| database_configuration() { | ||
| echo "Setting up the dolt database..." | ||
|
|
||
| read -e -p "Input the name of your database: " -i "doltdb" db_name |
There was a problem hiding this comment.
Too many doltdb references, just call this mydb or something
VinaiRachakonda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.