go/cmd/dolt: commands/sqlserver: Add configuration for disabling MULTI_STATEMENTS support on the server. #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I_STATEMENTS support on the server. Currently sql-server parses some MULTI_STATEMENTS incorrectly, in particular statements that include substatements get split up incorrectly. This adds server configuration for the yaml config, so that multi-statement handling can be disabled server-side. This will allow things like CREATE TRIGGERs submitted with a client that advertises MULTI_STATEMENTS support to work correctly with Dolt sql-server. However, if the client actually sends a multi-statement in this mode, even two SELECTs separated by a ';', for example, while the server is running in this mode, it will not work. To enable, place: ```yaml behavior: disable_client_multi_statements: false ``` in the config.yaml for the server.
zachmu
approved these changes
Dec 2, 2021
| host: "0.0.0.0" | ||
| port: $PORT | ||
| EOF | ||
| dolt sql-server --config ./config.yml & |
There was a problem hiding this comment.
You can use start_sql_server_with_config for this
…isable-multi-statements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sql-server parses some MULTI_STATEMENTS incorrectly, in particular
statements that include substatements get split up incorrectly. This adds
server configuration for the yaml config, so that multi-statement handling can
be disabled server-side. This will allow things like CREATE TRIGGERs submitted
with a client that advertises MULTI_STATEMENTS support to work correctly with
Dolt sql-server. However, if the client actually sends a multi-statement in
this mode, even two SELECTs separated by a ';', for example, while the server
is running in this mode, it will not work.
To enable, place:
in the config.yaml for the server.