Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to schema export/import command documentation #2681

Merged
merged 8 commits into from
Jan 28, 2022

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jan 25, 2022

No description provided.

* include CLI header section
* stop using entity chars in synopsis markdown sections
…rray causes the synopsis to not be printed at all.
@fulghum fulghum requested a review from zachmu January 28, 2022 00:43
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -43,7 +43,7 @@ Running dolt init in an already initialized directory will fail.
`,

Synopsis: []string{
//`[{{.LessThan}}options{{.GreaterThan}}] [{{.LessThan}}path{{.GreaterThan}}]`,
"",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an empty slice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it an empty slice will cause help and markdown to omit the synopsis section. Probably okay for this simple command, but it's nice for consistency in the docs for all commands to have the same sections.

@fulghum fulghum removed the request for review from andy-wm-arthur January 28, 2022 17:35
@fulghum fulghum merged commit 6043cbe into dolthub:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants