go/libraries/doltcore/dbfactory: Thread memory quota provider through store layer to onHeapTableIndex #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reltuk
approved these changes
Mar 24, 2022
go/store/nbs/table_set.go
Outdated
| ae.SetIfError(err) | ||
| return | ||
| } | ||
| err = ts.q.AcquireQuota(ctx, memSize) |
There was a problem hiding this comment.
This might work fine for now. But I'm concerned about the double-counting overhead when we're rebasing a large repository..AFAIU, the interaction is basically
newtableset, err := tableset.Rebase(...)
if err ...
tableset.Close()
tableset = newtableset
Also AFAIU, the mmap machinery already requires that explicitly manage the lifecycle of these index (.Clone()). So...one way to get around this double counting is by moving the ReleaseQuota call into the tableIndex Close() function (Close(ctx, MemoryQuotaProvider) error) and adding reference counting to onHeapTableIndex as well.
Any thoughts?
druvv
changed the title
|
tested these Dolt changes against LD tests just to make sure I didn't break something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows creators of noms block stores to manage memory resources related to them.