Only rebase transaction start for read replica #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#benchmark |
|
#newbenchmark |
…/dolt into max/only-rebase-for-read-replica
|
2 similar comments
|
|
|
|
These still aren't bad perf wine ~5-10% on most metrics. |
max-hoffman
commented
Jul 1, 2022
| } | ||
|
|
||
| // IsLocked returns true if this database's lockfile exists | ||
| func (dEnv *DoltEnv) IsLocked() bool { |
There was a problem hiding this comment.
should these be mutex protected?
zachmu
approved these changes
Jul 1, 2022
| @@ -35,6 +36,8 @@ import ( | |||
| "github.com/dolthub/dolt/go/libraries/doltcore/sqlserver" | |||
| ) | |||
|
|
|||
| var ErrActiveServerLock = errors.New("database locked by another sql-server; either clone the database to run a second server, or delete the '.dolt/sql-server.lock' if no other sql-servers are active") | |||
There was a problem hiding this comment.
Error message should have the absolute path to the lock file
| @@ -32,6 +33,8 @@ import ( | |||
| "github.com/dolthub/dolt/go/libraries/utils/filesys" | |||
| ) | |||
|
|
|||
| var ErrActiveServerLock = errors.New("database locked by another sql-server; either clone the database to run a second server, or delete the '.dolt/sql-server.lock' if no other sql-servers are active") | |||
There was a problem hiding this comment.
What's with the duplicate error def?
| @@ -2,7 +2,7 @@ | |||
| set -e | |||
| set -o pipefail | |||
|
|
|||
| SYSBENCH_TEST="oltp_point_select" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
.dolt/sql-server.lockthat is deleted when the server is terminated.ReadOnlymode. Bulk table import does not appear to respect read only mode, so it has an additional check.