dolt_clone stored procedure #3745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs tests but I'm not going to get to them before taking off on vacation. I'm putting it up for review because Jennifer has already merged some of these changes into her own branch, so it seems wise to get it checked in before it diverges too much. I can write bats tests when I'm back in town. |
|
Maybe Jennifer can write the tests for you?
…On Thu, Jul 14, 2022 at 3:03 PM Zach Musgrave ***@***.***> wrote:
This needs tests but I'm not going to get to them before taking off on
vacation. I'm putting it up for review because Jennifer has already merged
some of these changes into her own branch, so it seems wise to get it
checked in before it diverges too much. I can write bats tests when I'm
back in town.
—
Reply to this email directly, view it on GitHub
<#3745 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJAR3CHTLCYKEHXLXB7THTVUCFCLANCNFSM52N5TXCQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Actually did add a bats test, but it needs more |
|
I'll start digging into this one, review, and add some more tests so we can unblock Jennifer's dolt_remote change. |
fulghum
approved these changes
Jul 19, 2022
This was referenced Jul 19, 2022
…sn't a direct CLI command (and would cause SQL command usage to print); cleaning up whitespace.
… a copy instead of modifying the original struct, like their docs describe.
… working directory and causing incorrect behavior after running dolt_clone().
…g remote name, and cloning from DoltHub)
…ng a single branch.
fulghum
reviewed
Jul 21, 2022
| @@ -212,6 +215,87 @@ func (p DoltDatabaseProvider) CreateDatabase(ctx *sql.Context, name string) erro | |||
| return dsess.AddDB(ctx, dbstate) | |||
| } | |||
|
|
|||
| // CloneDatabaseFromRemote implements DoltDatabaseProvider interface | |||
| func (p DoltDatabaseProvider) CloneDatabaseFromRemote(ctx *sql.Context, dbName, branch, remoteName, remoteUrl string, remoteParams map[string]string) error { | |||
| p.mu.Lock() | |||
There was a problem hiding this comment.
This is potentially a loooong time to be holding a lock! I think this is okay for v1, since dolt_clone() will not be frequently used, but it would be good to follow up and shrink down the code that executes with this lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a new
dolt_clone()stored procedure.Removes most of the use of
os.Chdir(except for in test code and one or two dolt-cli-only spots).Doc Updates: dolthub/docs#804