go/store/types: SerialMessage: Unify TupleRowStorage and SerialMessage. #3899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrew-wm-arthur One question here would be if we should push FinishMessage(), MessagePrefixSz, MessageTypesKind, etc., into the |
Get rid of TupleRowStorage and use SerialMessage everywhere. In turn, change SerialMessage so that it carries its kind and size prefix as part of itself.
reltuk
force-pushed
the
aaron/unify-tuplerowstorage-serialmessage
branch
from
9f507df
to
4f3f4e1
Compare
andy-wm-arthur
approved these changes
Jul 22, 2022
…f encoding the value and hashing the chunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of TupleRowStorage and use SerialMessage everywhere. In turn, change
SerialMessage so that it carries its kind and size prefix as part of itself.