Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/cmd/dolt/commands/sql.go: Always close row iters. Improves robustness when SQL returns an error. #395

Merged
merged 3 commits into from
Feb 17, 2020
Merged

go/cmd/dolt/commands/sql.go: Always close row iters. Improves robustness when SQL returns an error. #395

merged 3 commits into from
Feb 17, 2020

Conversation

reltuk
Copy link
Contributor

@reltuk reltuk commented Feb 13, 2020

No description provided.

@reltuk reltuk requested a review from zachmu February 13, 2020 22:43
@reltuk
Copy link
Contributor Author

reltuk commented Feb 14, 2020

@zachmu Ready for review!

zachmu
zachmu approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch!

@timsehn
Copy link
Sponsor Contributor

timsehn commented Feb 17, 2020

Merging so we get this in the release.

@timsehn timsehn merged commit 22b4e97 into master Feb 17, 2020
@Hydrocharged Hydrocharged deleted the aaron/sql-close-rowiters branch February 18, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reltuk @timsehn @zachmu