Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Burlier tests for multi-db replication #4122

Merged
merged 1 commit into from Aug 17, 2022
Merged

Burlier tests for multi-db replication #4122

merged 1 commit into from Aug 17, 2022

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Aug 17, 2022

No description provided.

timsehn
timsehn reviewed Aug 17, 2022
View reviewed changes
Copy link
Sponsor Contributor

@timsehn timsehn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a create database/bootstrap w/ clone test?

max-hoffman
max-hoffman approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timsehn
timsehn reviewed Aug 17, 2022
View reviewed changes
Copy link
Sponsor Contributor

@timsehn timsehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have an explicit create database, set origin and then dolt clone, set replica test as well

@zachmu
Copy link
Member Author

zachmu commented Aug 17, 2022

I think we should have an explicit create database, set origin and then dolt clone, set replica test as well

I'll add a test for that when I make it work, definitely broken right now.

@zachmu zachmu merged commit 3302bb7 into main Aug 17, 2022
@Hydrocharged Hydrocharged deleted the zachmu/replication-tests branch October 13, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsehn timsehn timsehn left review comments

@max-hoffman max-hoffman max-hoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zachmu @timsehn @max-hoffman