Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize the map iterator used by the history table #417

Merged
merged 6 commits into from
Feb 25, 2020
Merged

optimize the map iterator used by the history table #417

merged 6 commits into from
Feb 25, 2020

Conversation

bheni
Copy link
Contributor

@bheni bheni commented Feb 24, 2020

No description provided.

@bheni bheni changed the base branch from master to bh/set-algebra February 24, 2020 02:13
@bheni bheni changed the title Bh/opt hist itr2 optimize the map iterator used by the history table Feb 24, 2020
@bheni bheni requested a review from zachmu February 24, 2020 08:41
zachmu
zachmu approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few comments

go/libraries/doltcore/sqle/expression_limited_map_reader.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/expression_limited_map_reader.go Show resolved Hide resolved
go/libraries/doltcore/sqle/expression_limited_map_reader.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/expression_limited_map_reader.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/expression_limited_map_reader.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/expression_limited_map_reader.go Outdated Show resolved Hide resolved
go/libraries/doltcore/table/typed/noms/range_reader.go
// Inclusive says whether the Start key should be included in the range.
Inclusive bool
// Reverse says if the range should be read in reverse (from high to low) instead of the default (low to high)
Reverse bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call this Ascending / Descending and make an enum type for it

go/libraries/doltcore/table/typed/noms/range_reader.go Show resolved Hide resolved
@bheni bheni merged commit 09378f8 into bh/set-algebra Feb 25, 2020
@bheni bheni deleted the bh/opt-hist-itr2 branch February 25, 2020 06:38
@bheni bheni mentioned this pull request Feb 25, 2020
Merged
bheni pushed a commit that referenced this pull request Feb 25, 2020
history table optimizations
26865a6 
* filter commits used by history table (#418)
* setalgebra package (#416)
* history table iterator optimizations (#417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bheni @zachmu