-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/go/libraries/doltcore/sqle/logictest/main/main.go: Add withdurations option #423
Conversation
…der "duration" field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as in the other repo. Just always parse durations, way simpler.
…n default behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, just one comment
@@ -91,6 +91,7 @@ func NewDoltRecordResult(e *logictest.ResultLogEntry) *DoltResultRecord { | |||
TestFile: e.TestFile, | |||
LineNum: e.LineNum, | |||
Query: e.Query, | |||
Duration: e.Duration.String(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make this a numeric type and specify units. We don't have a duration type in dolt.
@@ -91,6 +91,7 @@ func NewDoltRecordResult(e *logictest.ResultLogEntry) *DoltResultRecord { | |||
TestFile: e.TestFile, | |||
LineNum: e.LineNum, | |||
Query: e.Query, | |||
Duration: e.Duration.String(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would make this a numeric type and specify units. We don't have a duration type in dolt.
No description provided.