Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use commitItr instead of commitwalk for querying dolt_diff table #4243

Merged
merged 6 commits into from
Sep 7, 2022
Merged

use commitItr instead of commitwalk for querying dolt_diff table #4243

merged 6 commits into from
Sep 7, 2022

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Aug 30, 2022 •
edited

This improves select query on unscoped dolt_diff table in old format for commit_hash column filter

@timsehn timsehn linked an issue Aug 31, 2022 that may be closed by this pull request
Optimize dolt_diff system table access when scoped to a commit #4232
Closed
@timsehn timsehn mentioned this pull request Aug 31, 2022
Closed
fulghum
fulghum approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Jennifer! Just a couple of really minor comments from me. Good perf win for this table! 😎

go/libraries/doltcore/sqle/enginetest/dolt_queries.go Show resolved Hide resolved
go/libraries/doltcore/sqle/dtables/unscoped_diff_table.go Show resolved Hide resolved
go/libraries/doltcore/sqle/dtables/unscoped_diff_table.go Show resolved Hide resolved
go/libraries/doltcore/sqle/dtables/unscoped_diff_table.go Outdated Show resolved Hide resolved
@jennifersp jennifersp merged commit 67ddf5e into main Sep 7, 2022
@jennifersp jennifersp deleted the jennifer/dolt-diff-table branch September 7, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize dolt_diff system table access when scoped to a commit
2 participants
@jennifersp @fulghum