Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetOrdinal and GetRangeCardinality to prolly.Map #4247

Closed
wants to merge 6 commits into from
Closed

Add GetOrdinal and GetRangeCardinality to prolly.Map #4247

wants to merge 6 commits into from

Conversation

druvv
Copy link
Contributor

@druvv druvv commented Aug 31, 2022

No description provided.

andy-wm-arthur
andy-wm-arthur approved these changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, doesn't have any test coverage for computing the ordinal or a non-member key

go/store/prolly/tree/node_cursor.go Outdated Show resolved Hide resolved
go/store/prolly/tree/node_cursor.go Outdated Show resolved Hide resolved
andy-wm-arthur
andy-wm-arthur approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, clean up GetRangeCardinality if you're not using it

go/store/prolly/map.go Show resolved Hide resolved
go/store/prolly/map.go Show resolved Hide resolved
go/store/prolly/map_test.go Show resolved Hide resolved
@druvv druvv mentioned this pull request Sep 1, 2022
Merged
@druvv druvv closed this Sep 2, 2022
@Hydrocharged Hydrocharged deleted the dhruv/key-range-cardinality branch October 13, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-wm-arthur andy-wm-arthur andy-wm-arthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@druvv @andy-wm-arthur