-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unskipping commit DiffSystemTableTests #4257
Conversation
…to james/prepareds5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
} | ||
} | ||
eqFilter, isEquality := filter.(*expression.Equals) | ||
if eqFilter == nil || !isEquality { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is redundant, just check the ok
return commitFilters | ||
} | ||
|
||
// Filters returns the list of filters that are applied to this table. | ||
func (dt *CommitDiffTable) Filters() []sql.Expression { | ||
if dt.toCommitFilter == nil || dt.fromCommitFilter == nil { | ||
return nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this probably isn't OK, can't return nil filters, have to add all non-nils to a return list
No description provided.