[store/prolly] Add DiffKeyRangeMaps and IterKeyRange #4258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-wm-arthur
approved these changes
Sep 1, 2022
Comment on lines
+127
to
131
| // RangeDiffMaps returns diffs within a Range. See Range for which diffs are | ||
| // returned. | ||
| func RangeDiffMaps(ctx context.Context, from, to Map, rng Range, cb DiffFn) error { | ||
| return rangeDiffOrderedTrees(ctx, from.tuples, to.tuples, rng, cb) | ||
| } |
There was a problem hiding this comment.
Do we have a use case for this old function, given the new one?
There was a problem hiding this comment.
I believe we do. We could implement range diffs in the sql layer for our diff tables instead of applying a filter.
| // IterKeyRange iterates over a physical key range defined by |startInclusive| | ||
| // and |stopExclusive|. If |startInclusive| and/or |stopExclusive| is nil, the | ||
| // range will be open towards that end. | ||
| func (m Map) IterKeyRange(ctx context.Context, startInclusive, stopExclusive val.Tuple) (MapIter, error) { |
There was a problem hiding this comment.
Suggested change
| func (m Map) IterKeyRange(ctx context.Context, startInclusive, stopExclusive val.Tuple) (MapIter, error) { | |
| func (m Map) IterKeyRange(ctx context.Context, start, stop val.Tuple) (MapIter, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.