Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix enum panics in history table #4283

Merged
merged 6 commits into from
Sep 7, 2022
Merged

fix enum panics in history table #4283

merged 6 commits into from
Sep 7, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Sep 7, 2022 •
edited

Closes: #4279

sql.enumtype contains a map, which in golang cannot be used in == operator

@jycor jycor requested a review from fulghum September 7, 2022 20:16
fulghum
fulghum approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this one James! ⚡

@jycor jycor merged commit ddd7bad into main Sep 7, 2022
@Hydrocharged Hydrocharged deleted the james/enum branch October 13, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dolt_history_<table> panics on enum types
2 participants
@jycor @fulghum