add nil check for string pointers during dolt table import #4284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Sep 7, 2022
| [ "$status" -eq 1 ] | ||
| [[ "$output" =~ "A bad row was encountered while moving data" ]] || false | ||
| [[ "$output" =~ "CSV reader expected 3 values, but saw 4" ]] || false | ||
| [[ "$output" =~ "row values:" ]] |
There was a problem hiding this comment.
do you need the || false at the end of this line 1240, too?
There was a problem hiding this comment.
thanks for catch, I definitely do
There was a problem hiding this comment.
As a bit of trivia. This is only necessary because of the ancient version of bash that ships with MacOS. Without it, that equality may show true when false non-deterministically.
There was a problem hiding this comment.
🦇 🦇 🦇 @timsehn == BATSman 🦇 🦇 🦇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4209