Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding prepared tests for dolt stored procedures #4399

Merged
merged 5 commits into from
Sep 23, 2022
Merged

adding prepared tests for dolt stored procedures #4399

merged 5 commits into from
Sep 23, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Sep 22, 2022 •
edited

Fix for: #4392

zachmu
zachmu approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go/libraries/doltcore/sqle/enginetest/dolt_queries.go Outdated
},
Assertions: []queries.ScriptTestAssertion{
{
Query: "SELECT message from dolt_log LIMIT 1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use an order by or where clause, no guarantee this is the row you get otherwise

@jycor jycor merged commit c052449 into main Sep 23, 2022
@Hydrocharged Hydrocharged deleted the james/bindvars branch October 13, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jycor @zachmu