Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reorder arguments of dolt_diff() table function #4408

Merged
merged 4 commits into from
Sep 26, 2022
Merged

reorder arguments of dolt_diff() table function #4408

merged 4 commits into from
Sep 26, 2022

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Sep 26, 2022 •
edited

This PR updates argument ordering of dolt_diff() table function to match dolt_diff_summary() table function, which matches CLI command argument order.

@jennifersp jennifersp mentioned this pull request Sep 26, 2022
Merged
fulghum
fulghum approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice change for consistency across these functions. 🙏

I'm happy to review the corresponding doc updates, too, when you've got 'em.

@jennifersp jennifersp merged commit f4be51d into main Sep 26, 2022
@jennifersp jennifersp deleted the jennifer/diff-tf branch September 26, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jennifersp @fulghum