Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walk artifacts ref #4438

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Walk artifacts ref #4438

merged 2 commits into from
Sep 30, 2022

Conversation

druvv
Copy link
Contributor

@druvv druvv commented Sep 30, 2022 •
edited

  • Reordered table serial message address walk to match the definitions in table.fbs
  • Now walks artifact ref hash. Previously we were not walking it :(

andy-wm-arthur
andy-wm-arthur approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integration-tests/bats/garbage_collection.bats Outdated Show resolved Hide resolved
@druvv druvv merged commit 272ca59 into main Sep 30, 2022
@Hydrocharged Hydrocharged deleted the dhruv/walk-artifacts branch October 13, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-wm-arthur andy-wm-arthur andy-wm-arthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@druvv @andy-wm-arthur