go: sqle: cluster: When the server has role "standby", make all dolt databases read-only. #4443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions when transition server role.
…cept writes when the server transitions to primary.
…ion server cluster role when they see a newer primary.
… see two primaries at the same epoch.
…acefully when going primary -> standby. Fail if it cannot true-up the peer.
…ctions when transition server role.
…cept writes when the server transitions to primary.
…ion server cluster role when they see a newer primary.
… see two primaries at the same epoch.
…ron/sql-cluster-standby-is-read-only
…cluster-interceptors-transition-role
… requests when we are DetectedBrokenConfig as well.
…ron/sql-cluster-graceful-transition
…commits when we are not primary.
…having all writes.
andy-wm-arthur
approved these changes
Sep 30, 2022
| // happening. | ||
| if err := c.waitForHooksToReplicate(); err != nil { | ||
| c.setProviderIsStandby(false) | ||
| c.killRunningQueries() |
There was a problem hiding this comment.
why do we call this again here?
There was a problem hiding this comment.
Because connections could have come in while we were trying to true up the standby and they will have busted InitialDbStates and stuff in their session.
…-test bats: cluster: Add a test for a couple failovers and the new primary having all writes.
…mmit-hook-as-standby go: sqle: cluster: commithook: Log warnings when the commithook sees commits when we are not primary.
…sition go: sqle: cluster: Have call dolt_assume_cluster_role() transition gracefully when going primary -> standby. Fail if it cannot true-up the peer.
…transition-role go: sqle: cluster: Have remotesapi client and server interceptors transition server cluster role if they notice a new primary or broken cluster configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.