/bats/remotes-file-system.bats: Add skipped bats test for fetch display branch bug #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-wm-arthur
suggested changes
Mar 6, 2020
| run dolt branch | ||
| [ "$status" -eq 0 ] | ||
| [[ "${lines[0]}" =~ "master" ]] || false | ||
| skip "Fetched branch not displayed in branch list" [[ "${lines[1]}" =~ "tester" ]] || false |
There was a problem hiding this comment.
skip "..." exits the test the first time it's called, there's no need to call it again
bats/remotes-file-system.bats
Outdated
| skip "Allows creation of branch with same name as remote branch" [[ "${lines[0]}" =~ "fatal: A branch named 'tester' already exists." ]] || false | ||
|
|
||
| # should not be able to checkout branch that is not displayed | ||
| skip "Allows checkout of branch not displayed in branch list" run dolt checkout tester |
There was a problem hiding this comment.
once the bug is fixed, the checks on 191 & 192 will fail because tester will be fetched on 175
|
good catch! |
… will pass when bug is fixed
andy-wm-arthur
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.