Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join ordering GMS bump #4516

Merged
merged 21 commits into from
Oct 25, 2022
Merged

join ordering GMS bump #4516

merged 21 commits into from
Oct 25, 2022

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Oct 11, 2022

@max-hoffman
Copy link
Contributor Author

#benchmark

@github-actions
Copy link

@github-actions
Copy link

@max-hoffman DOLT

test_name from_latency_median to_latency_median is_faster
tpcc-scale-factor-1 186.54 193.38 0
test_name server_name server_version tps test_name server_name server_version tps is_faster
tpcc-scale-factor-1 dolt 7d81a09 25.65 tpcc-scale-factor-1 dolt a383a82 23.21 0

@github-actions
Copy link

@max-hoffman LD_1

test_name from_latency_median to_latency_median is_faster
tpcc-scale-factor-1 3574.99 2985.89 0
test_name server_name server_version tps test_name server_name server_version tps is_faster
tpcc-scale-factor-1 dolt 7d81a09 1.38 tpcc-scale-factor-1 dolt a383a82 1.68 0

@github-actions
Copy link

@max-hoffman LD_1

read_tests from_latency_median to_latency_median is_faster
covering_index_scan 7.04 7.04 0
groupby_scan 23.52 23.52 0
index_join 17.32 17.32 0
index_join_scan 16.71 16.71 0
index_scan 73.13 74.46 0
oltp_point_select 1.08 1.08 0
oltp_read_only 11.24 11.24 0
select_random_points 1.93 1.93 0
select_random_ranges 1.93 1.89 0
table_scan 70.55 70.55 0
types_table_scan 223.34 219.36 0
write_tests from_latency_median to_latency_median is_faster
bulk_insert 0.001 0.001 0
oltp_delete_insert 23.52 23.1 0
oltp_insert 9.91 9.91 0
oltp_read_write 41.1 41.1 0
oltp_update_index 11.24 11.24 0
oltp_update_non_index 8.28 8.28 0
oltp_write_only 30.81 30.26 0
types_delete_insert 161.51 164.45 0

@github-actions
Copy link

@max-hoffman DOLT

read_tests from_latency_median to_latency_median is_faster
covering_index_scan 2.66 2.76 0
groupby_scan 17.32 17.32 0
index_join 4.57 4.65 0
index_join_scan 3.89 3.96 0
index_scan 53.85 53.85 0
oltp_point_select 0.47 0.47 0
oltp_read_only 8.74 8.74 0
select_random_points 0.75 0.75 0
select_random_ranges 1.14 1.12 0
table_scan 63.32 62.19 0
types_table_scan 186.54 186.54 0
write_tests from_latency_median to_latency_median is_faster
bulk_insert 0.001 0.001 0
oltp_delete_insert 9.91 8.9 1
oltp_insert 2.76 2.76 0
oltp_read_write 17.01 16.41 0
oltp_update_index 4.49 4.1 0
oltp_update_non_index 4.82 4.25 1
oltp_write_only 7.98 7.7 0
types_delete_insert 11.04 9.91 1

@timsehn
Copy link
Sponsor Contributor

timsehn commented Oct 24, 2022

Beautiful!

@max-hoffman
Copy link
Contributor Author

@max-hoffman DOLT

read_tests from_latency_median to_latency_median is_faster
covering_index_scan 2.66 2.76 0
groupby_scan 17.32 17.32 0
index_join 4.57 4.65 0
index_join_scan 3.89 3.96 0
index_scan 53.85 53.85 0
oltp_point_select 0.47 0.47 0
oltp_read_only 8.74 8.74 0
select_random_points 0.75 0.75 0
select_random_ranges 1.14 1.12 0
table_scan 63.32 62.19 0
types_table_scan 186.54 186.54 0
write_tests from_latency_median to_latency_median is_faster
bulk_insert 0.001 0.001 0
oltp_delete_insert 9.91 8.9 1
oltp_insert 2.76 2.76 0
oltp_read_write 17.01 16.41 0
oltp_update_index 4.49 4.1 0
oltp_update_non_index 4.82 4.25 1
oltp_write_only 7.98 7.7 0
types_delete_insert 11.04 9.91 1

I wish i could explain the change, in the past this signal has been caused by skipped correctness checks. We have passing tests that suggests that isn't the case here, though.

@max-hoffman max-hoffman merged commit b351314 into main Oct 25, 2022
@max-hoffman max-hoffman deleted the max/new-joins-GMS-bump branch October 25, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants