Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch Control Pt. 9 #4585

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Branch Control Pt. 9 #4585

merged 1 commit into from
Oct 25, 2022

Conversation

Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Oct 20, 2022 •
edited

This PR:

  • Moves the branch controller into the context
  • Adds the remaining stored procedures
  • Handles declaring the super user via CLI arguments or YAML
  • Fixes bugs found through additional testing
  • Enables branch control globally

Things still missing:

  • Bats tests (will mainly copy the engine tests, but makes use of saving/loading from disk)
  • Ways to interact with the binlog
  • Support for roles

Role support is actually a bit more involved than originally anticipated. It involves coordination with the privilege tables, which were not built to be interacted with outside of their specific GMS context. I'm thinking it should get pushed back to a v2 implementation, unless it's high priority.

@Hydrocharged Hydrocharged force-pushed the daylon/bc-cleanup branch 2 times, most recently from 553d624 to b979baf Compare October 20, 2022 16:45
zachmu
zachmu approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go/cmd/dolt/commands/engine/sqlengine.go Outdated Show resolved Hide resolved
go/cmd/dolt/commands/sqlserver/server.go Show resolved Hide resolved
go/libraries/doltcore/branch_control/branch_control.go Show resolved Hide resolved
go/libraries/doltcore/branch_control/branch_control.go Show resolved Hide resolved
go/libraries/doltcore/branch_control/branch_control.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/dfunctions/verify_constraints.go Show resolved Hide resolved
go/libraries/doltcore/sqle/dprocedures/dolt_remote.go Show resolved Hide resolved
go/libraries/doltcore/sqle/dprocedures/dolt_tag.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit 8253629 into main Oct 25, 2022
@Hydrocharged Hydrocharged deleted the daylon/bc-cleanup branch October 25, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hydrocharged @zachmu