Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dolt sql server docker image #4605

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Add dolt sql server docker image #4605

merged 5 commits into from
Oct 24, 2022

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Oct 24, 2022

Adds Docker Image for dolt sql-server. The server starts at 0.0.0.0:3306, which allow connections from outside the container through port-mapping. User can define host and port through yaml configuration. The data directory is default to /var/lib/dolt/ directory in the container. It can be mounted with directory on host system. It's not recommended to define data_dir in configuration, which will cause mounting host system directory fail.

Copy link
Contributor

@coffeegoddd coffeegoddd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! great job

@jennifersp jennifersp merged commit 9a50c1e into main Oct 24, 2022
@jennifersp jennifersp deleted the jennifer/sql-server-image branch October 24, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants