Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zachmu/as of #468

Merged
merged 14 commits into from
Mar 17, 2020
Merged

Zachmu/as of #468

merged 14 commits into from
Mar 17, 2020

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Mar 14, 2020

Dolt support for AS OF queries.

This won't build until dolthub/go-mysql-server#71 is merged and dependencies updated.

@zachmu
First pass at historical queries for dolt tables
6257cc0 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Made DoltDatabase's table cache aware of different roots
ff9d894 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Rewrote historical table as versioned database
fb3bc4d 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
go.mod with local overrides
b16c96a 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
go.sum local override
7b49cb7 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Select tests for AS OF
5ed22fe 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Added bats test
197b09e 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Working AS OF bats test.
c2efee8 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Added new GetTableNamesAsOf method to DoltDatabase
12a9db0 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Added tests of AS OF for commit hash
77798e4 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu zachmu requested a review from bheni March 14, 2020 23:47
bheni
bheni approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@bheni bheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Few comments

go/libraries/doltcore/sql/sqltestutil/selectqueries.go Show resolved Hide resolved
go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/database.go Outdated Show resolved Hide resolved
@zachmu
Updated sql dependencies
efcc05d 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Added support and tests for AS OF refs such as HEAD, HEAD~, etc
5a1acc0 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Tests of HEAD~ AS OF queries
fb85bee 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu
Formatting changes
8425ea5 
Signed-off-by: Zach Musgrave <zach@liquidata.co>
@zachmu zachmu merged commit 1f7b1f9 into master Mar 17, 2020
@Hydrocharged Hydrocharged deleted the zachmu/as-of branch April 8, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bheni bheni bheni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zachmu @bheni