Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a panic that occurs when grpc stream Recv() method returns an err… #4784

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fix a panic that occurs when grpc stream Recv() method returns an err… #4784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion go/libraries/doltcore/remotestorage/chunk_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,11 @@ func (dcs *DoltChunkStore) getDLLocs(ctx context.Context, hashes []hash.Hash) (d
if err == io.EOF {
return nil
}
return NewRpcError(err, "StreamDownloadLocations", dcs.host, reqs[completedReqs])
var r *remotesapi.GetDownloadLocsRequest
if completedReqs < len(reqs) {
r = reqs[completedReqs]
}
return NewRpcError(err, "StreamDownloadLocations", dcs.host, r)
}
if resp.RepoToken != "" {
dcs.repoToken.Store(resp.RepoToken)
Expand Down