Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dolt init fails with invalid arguments #4815

Merged
merged 1 commit into from Nov 18, 2022
Merged

dolt init fails with invalid arguments #4815

merged 1 commit into from Nov 18, 2022

Conversation

jennifersp
Copy link
Contributor

No description provided.

@jennifersp jennifersp linked an issue Nov 17, 2022 that may be closed by this pull request
dolt init doesn't fail when a non-option argument is provided #4771
Closed
fulghum
fulghum approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good fix for the init command. Would be good to think about how we could do this more generally, for both CLI commands and SQL builtin procedures.

@jennifersp jennifersp merged commit d1d1928 into main Nov 18, 2022
@jennifersp jennifersp deleted the jennifer/init branch November 18, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dolt init doesn't fail when a non-option argument is provided
2 participants
@jennifersp @fulghum