Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/doltcore/migrate: added --drop-conflicts flag to migration, check … #4820

Merged
merged 3 commits into from Nov 18, 2022

Conversation

andy-wm-arthur
Copy link
Contributor

@andy-wm-arthur andy-wm-arthur commented Nov 17, 2022

…for migrated databases

fix for #4790

Copy link
Contributor

@druvv druvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thought of a couple cases for bats

run dolt migrate
[ $status -eq 0 ]
[[ "$output" =~ "already migrated" ]] || false
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other cases to write bats for:

  • Committed conflicts
  • Conflicts on a non-checked out working sets. (Different branch)

integration-tests/bats/migrate.bats Outdated Show resolved Hide resolved
Co-authored-by: Dhruv Sringari <dhruv@dolthub.com>
@andy-wm-arthur andy-wm-arthur merged commit aaa1e62 into main Nov 18, 2022
@andy-wm-arthur andy-wm-arthur deleted the andy/migration-patch branch November 18, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants