Andy/ci compatibility #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-wm-arthur
commented
Mar 20, 2020
go/cmd/dolt/commands/status.go
Outdated
| @@ -97,7 +97,7 @@ func (cmd StatusCmd) Exec(ctx context.Context, commandStr string, args []string, | |||
| } | |||
|
|
|||
| printStatus(ctx, dEnv, stagedTblDiffs, notStagedTblDiffs, workingTblsInConflict, workingDocsInConflict, stagedDocDiffs, notStagedDocDiffs) | |||
| return 0 | |||
| return 1 | |||
There was a problem hiding this comment.
@reltuk I added this commit to fail the compatibility tests
There was a problem hiding this comment.
This was going to be a lot cleaner, but then the windows tests failed and I had to rebase off of master. Please see build #2 for confirmation that exit codes work correctly.
andy-wm-arthur
force-pushed
the
andy/ci_compatibility
branch
from
ab91e9c
to
9b4d2be
Compare
andy-wm-arthur
force-pushed
the
andy/ci_compatibility
branch
from
335d928
to
b6b0506
Compare
andy-wm-arthur
force-pushed
the
andy/ci_compatibility
branch
from
e8ed89b
to
994a30b
Compare
… testing; cleanup test setup for forwards/backwards compatibility testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.