-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bats test for binary string encoded to utf8 #5294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this needs to be in server mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks good. Tim has a good comment about whether we could just use dolt sql
instead of going through a sql-server. From what we just discussed, it seems like it's true that dolt sql
should be enough to trigger the issue? Could you test that out and confirm?
@coffeegoddd DOLT
|
@coffeegoddd DOLT
|
Depends on dolthub/go-mysql-server#1583
DataGrip sets the
character_set_results
system variable toutf8
, which raw binary strings cannot be encoded into. MySQL returns binary type strings in hex format.