Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bats test for binary string encoded to utf8 #5294

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Feb 2, 2023

Depends on dolthub/go-mysql-server#1583
DataGrip sets the character_set_results system variable to utf8, which raw binary strings cannot be encoded into. MySQL returns binary type strings in hex format.

Copy link
Sponsor Contributor

@timsehn timsehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this needs to be in server mode.

integration-tests/bats/sql-server.bats Show resolved Hide resolved
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good. Tim has a good comment about whether we could just use dolt sql instead of going through a sql-server. From what we just discussed, it seems like it's true that dolt sql should be enough to trigger the issue? Could you test that out and confirm?

@jennifersp jennifersp merged commit 0e105b8 into main Feb 7, 2023
@jennifersp jennifersp deleted the jennifer/bats-test branch February 7, 2023 22:47
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.07 1.14
batching batch sql 10000 1 0.11 3.55
batching by line sql 10000 1 0.11 1.73
blob 1 blob 200000 1 1.2 3.58 3.88
blob 2 blobs 200000 1 1.19 4.86 5.08
blob no blob 200000 1 1.19 1.66 1.84
col type datetime 200000 1 1.08 2.12 2.35
col type varchar 200000 1 0.97 2.35 2.52
config width 2 cols 200000 1 0.98 1.69 1.85
config width 32 cols 200000 1 2.5 1.72 2.56
config width 8 cols 200000 1 1.25 1.73 2.2
pk type float 200000 1 1.15 1.45 1.64
pk type int 200000 1 0.99 2.02 1.82
pk type varchar 200000 1 2.09 1.03 1.19
row count 1.6mm 1600000 1 7.31 1.93 2.06
row count 400k 400000 1 1.9 1.87 1.93
row count 800k 800000 1 3.73 1.9 2.03
secondary index four index 200000 1 5.46 0.97 1.03
secondary index no secondary 200000 1 1.2 1.63 1.79
secondary index one index 200000 1 1.55 1.75 1.95
secondary index two index 200000 1 2.92 1.21 1.33
sorting shuffled 1mm 1000000 0 7.76 1.95 1.99
sorting sorted 1mm 1000000 1 7.53 2 2.1

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

@coffeegoddd DOLT

name mean mean_mult
dolt_commits_commit_filter 0.33 1
dolt_diff_log_join_from_commit 102.6 1.5
dolt_blame_basic 37.04 1.4
dolt_blame_commit_filter 192.79 2.74
dolt_commit_ancestors_commit_filter 0.32 0.97
dolt_diffs_commit_filter 0.39 1.15
dolt_diff_log_join_to_commit 100.96 1.48
dolt_history_commit_filter 0.6 1.54
dolt_diff_table_from_commit_filter 0.64 1.21
dolt_diff_table_to_commit_filter 0.62 1.17
dolt_log_commit_filter 0.33 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants