Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic for unexpected json file format #5302

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Feb 3, 2023

returns error message instead of panic

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks great! I just had one note to update the dolt table import docs, too, so that the JSON format we require is documented there, too, in addition to in this new error message.

Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for iterating on the details.

@jennifersp jennifersp merged commit 463e931 into main Feb 7, 2023
@jennifersp jennifersp deleted the jennifer/json-format branch February 7, 2023 01:55
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 1
batching batch sql 10000 1 0.08 1.75
batching by line sql 10000 1 0.07 2
blob 1 blob 200000 1 1.01 3.32 3.61
blob 2 blobs 200000 1 0.99 4.39 4.82
blob no blob 200000 1 1 1.67 1.78
col type datetime 200000 1 0.97 1.92 2.14
col type varchar 200000 1 0.76 2.24 2.7
config width 2 cols 200000 1 0.84 1.6 1.75
config width 32 cols 200000 1 1.89 1.85 2.64
config width 8 cols 200000 1 1.02 2.2 2.26
pk type float 200000 1 0.95 1.42 1.61
pk type int 200000 1 0.84 1.6 1.75
pk type varchar 200000 1 1.67 1.95 2.05
row count 1.6mm 1600000 1 6.46 1.76 1.95
row count 400k 400000 1 1.63 1.71 1.9
row count 800k 800000 1 3.27 1.72 1.91
secondary index four index 200000 1 4.48 1.42 1.46
secondary index no secondary 200000 1 0.99 1.62 1.91
secondary index one index 200000 1 1.29 1.72 1.95
secondary index two index 200000 1 2.38 1.47 1.66
sorting shuffled 1mm 1000000 0 6.37 1.98 1.97
sorting sorted 1mm 1000000 1 5.82 2.13 2.3

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@coffeegoddd DOLT

name mean mean_mult
dolt_blame_basic 43.1 1.33
dolt_blame_commit_filter 242.44 3.03
dolt_commit_ancestors_commit_filter 0.47 1.02
dolt_commits_commit_filter 0.47 1.02
dolt_diff_log_join_from_commit 137.07 1.44
dolt_diffs_commit_filter 0.54 1.06
dolt_diff_log_join_to_commit 135.51 1.42
dolt_history_commit_filter 0.77 1.38
dolt_diff_table_from_commit_filter 0.88 1.24
dolt_diff_table_to_commit_filter 0.88 1.29
dolt_log_commit_filter 0.49 1.02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to Import Nested JSON Objects to Dolt can Cause Dolt to Crash
2 participants