Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix --track for dolt_checkout #5348

Merged
merged 3 commits into from
Feb 14, 2023
Merged

fix --track for dolt_checkout #5348

merged 3 commits into from
Feb 14, 2023

Conversation

stephkyou
Copy link
Contributor

@stephkyou stephkyou commented Feb 13, 2023

--track is not working with call dolt_checkout as expected. This change updates dolt_checkout to mirror the before of dolt checkout in the CLI.

fixes: #5189

@stephkyou stephkyou marked this pull request as ready for review February 13, 2023 21:54
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just one suggestion for a couple more test cases to cover in BATS.

[[ ! "$output" =~ "other" ]] || false

run dolt sql << SQL
call dolt_checkout('--track', 'origin/other');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to test another form of using --track, such as if a local branch name is supplied or to test the error case where no arg supplied to --track should return an error message.

@stephkyou stephkyou merged commit 149e4af into main Feb 14, 2023
@stephkyou stephkyou deleted the steph/dolt-5189 branch February 14, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--track does not work in call dolt_checkout
2 participants