Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{bats,go}: Log successful commits #55

Merged
merged 2 commits into from Aug 27, 2019
Merged

{bats,go}: Log successful commits #55

merged 2 commits into from Aug 27, 2019

Conversation

mjesuele
Copy link

@mjesuele mjesuele commented Aug 27, 2019 •
edited

This closes https://github.com/liquidata-inc/ld/issues/1744

Before:

$ dolt commit -m "commit ints"

After:

$ dolt commit -m "commit ints"
commit 3cvbeh6bn94hlhfaig5pa65peiribrhn
Author: Matt Jesuele <matt@liquidata.co>
Date:   Mon Aug 26 19:10:17 -0700 2019

	commit ints

@mjesuele mjesuele requested review from timsehn and bheni August 27, 2019 02:11
@mjesuele mjesuele self-assigned this Aug 27, 2019
@mjesuele
Copy link
Author

The CI failure for this has nothing to do with the functionality being introduced; it is an ambient Windows test issue. This is ready for review/merge.

@bheni
Copy link
Contributor

bheni commented Aug 27, 2019

lgtm

@mjesuele mjesuele merged commit 2c5a321 into master Aug 27, 2019
@mjesuele mjesuele deleted the mj/commit-output branch August 27, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bheni bheni bheni approved these changes

@timsehn timsehn Awaiting requested review from timsehn

Assignees

@mjesuele mjesuele

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjesuele @bheni