Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test CI with automatic server connection for CLI commands. #6060

Merged
merged 8 commits into from
Jun 1, 2023

Conversation

nicktobey
Copy link
Contributor

@nicktobey nicktobey commented May 30, 2023

This adds additional CI workflows that start a Dolt SQL server before running the bats tests. The dolt commands in the tests should connect to the running server instead of running their own engine.

The file local-remote.bats contains a list of bats files that are not yet confirmed to work against a remote server because they contain dolt commands that haven't been migrated yet. This is a burndown list that will shrink as we migrate more commands.

@nicktobey nicktobey marked this pull request as draft May 30, 2023 22:50
Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions, but this will be really cool to have.

Please update the title before shipping :)

.github/workflows/ci-bats-unix.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@macneale4 macneale4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the description and title, then ship it!

@nicktobey nicktobey changed the title DO NOT SUBMIT / DRAFT Test CI with automatic server connection for CLI commands. Test CI with automatic server connection for CLI commands. Jun 1, 2023
@nicktobey nicktobey marked this pull request as ready for review June 1, 2023 20:17
@nicktobey nicktobey merged commit 6973ce3 into main Jun 1, 2023
11 checks passed
@nicktobey nicktobey deleted the nicktobey/bats branch June 1, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants