/bats/arg-parsing.bats: Add skipped test for checkout panic #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsehn
requested changes
Apr 23, 2020
bats/arg-parsing.bats
Outdated
| @@ -45,3 +45,13 @@ teardown() { | |||
| skip "Can't chain modal arguments" | |||
| dolt table import -fc test `batshelper 1pk5col-ints.csv` | |||
| } | |||
|
|
|||
| @test "dolt does not panic and returns error when empty string used with checkout" { | |||
There was a problem hiding this comment.
dolt checkout with empty string returns error
bats/arg-parsing.bats
Outdated
| @test "dolt does not panic and returns error when empty string used with checkout" { | ||
| run dolt checkout "" | ||
| skip "Panics when attempting to checkout empty string" [[ "$output" =~ "error: cannot checkout empty string" ]] || false | ||
| [ $status -eq 2 ] |
There was a problem hiding this comment.
we've been going with [ $status -ne 0 ]
bats/arg-parsing.bats
Outdated
|
|
||
| @test "dolt does not panic and returns error when empty string used with checkout" { | ||
| run dolt checkout "" | ||
| skip "Panics when attempting to checkout empty string" [[ "$output" =~ "error: cannot checkout empty string" ]] || false |
There was a problem hiding this comment.
add a newline here.
bats/arg-parsing.bats
Outdated
|
|
||
| run dolt checkout -b "" | ||
| [[ "$output" =~ "error: cannot checkout empty string" ]] || false | ||
| [ $status -eq 2 ] |
timsehn
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.