Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bulk_insert CI benchmark #6935

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Remove bulk_insert CI benchmark #6935

merged 1 commit into from
Nov 2, 2023

Conversation

max-hoffman
Copy link
Contributor

No description provided.

timsehn
timsehn reviewed Nov 2, 2023
View reviewed changes
Copy link
Sponsor Contributor

@timsehn timsehn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still run it but just not report the stats?

@timsehn
Copy link
Sponsor Contributor

timsehn commented Nov 2, 2023

We should definitely merge this. It's better than having 0 and making us look better than we are.

@max-hoffman
Copy link
Contributor Author

Does this still run it but just not report the stats?

Pretty sure it will not run, but not 100% confident.

@max-hoffman max-hoffman merged commit d256c49 into main Nov 2, 2023
16 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 3, 2023
Merged
@Hydrocharged Hydrocharged deleted the max/no-bulk-insert-benchmark branch February 7, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timsehn timsehn timsehn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@max-hoffman @timsehn