Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for listing all entries in dolt_reflog() #6937

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Nov 2, 2023

Allows dolt_reflog() to be called without any arguments to list the contents of the reflog/chunk journal. Internal ref types and ref types that don't always point to a commit (i.e. working set refs) are still excluded.

While testing this, I realized that we needed to change to iterate the chunk journal roots in order (instead of in reverse order), otherwise we don't identify the correct, first root where a ref was set to a new value and the ref updates don't appear in the right order in the reflog.

@fulghum fulghum requested a review from zachmu November 2, 2023 21:24
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, nice change!

go/store/nbs/journal.go Outdated Show resolved Hide resolved
@fulghum fulghum merged commit 4e69a76 into fulghum/reflog Nov 2, 2023
2 checks passed
@fulghum fulghum deleted the fulghum/reflog-all-refs branch November 2, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants