Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing large numeric types #709

Merged
merged 2 commits into from May 27, 2020
Merged

testing large numeric types #709

merged 2 commits into from May 27, 2020

Conversation

andy-wm-arthur
Copy link
Contributor

No description provided.

Hydrocharged
Hydrocharged approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dig it!

@Hydrocharged
Copy link
Contributor

You may want to throw DECIMAL in there as well.

For DECIMAL(65,0) you could test:
"99999999999999999999999999999999999999999999999999999999999999999"
99999999999999999999999999999999999999999999999999999999999999999 and
99999999999999999999999999999999999999999999999999999999999999999.0

For DECIMAL(65,30):
"99999999999999999999999999999999999.999999999999999999999999999999" and 99999999999999999999999999999999999.999999999999999999999999999999

You could also throw in negative tests for all of them too.

@andy-wm-arthur andy-wm-arthur merged commit 2e265d9 into master May 27, 2020
@andy-wm-arthur andy-wm-arthur deleted the andy/numeric-types-bats branch May 28, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andy-wm-arthur @Hydrocharged