Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign Keys Part 3 #753

Merged
merged 4 commits into from Jun 25, 2020
Merged

Foreign Keys Part 3 #753

merged 4 commits into from Jun 25, 2020

Conversation

Hydrocharged
Copy link
Contributor

This PR implements the commit functionality, along with commit --force.

@Hydrocharged Hydrocharged requested a review from zachmu June 23, 2020 09:49
zachmu
zachmu approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few comments.

go/libraries/doltcore/env/actions/commit.go Outdated Show resolved Hide resolved
go/libraries/doltcore/doltdb/root_val.go Outdated Show resolved Hide resolved
go/libraries/doltcore/doltdb/root_val.go Outdated Show resolved Hide resolved
go/libraries/doltcore/doltdb/root_val.go Outdated Show resolved Hide resolved
go/libraries/doltcore/doltdb/root_val.go Show resolved Hide resolved
go/libraries/doltcore/doltdb/foreign_key_coll.go Outdated Show resolved Hide resolved
go/libraries/doltcore/doltdb/foreign_key_coll.go Outdated Show resolved Hide resolved
bats/foreign-keys.bats Show resolved Hide resolved
@Hydrocharged Hydrocharged mentioned this pull request Jun 25, 2020
Closed
@Hydrocharged Hydrocharged changed the base branch from daylon/foreign-keys-2-ep1 to master June 25, 2020 08:00
@Hydrocharged
Copy link
Contributor Author

PRs #744 #748 have been merged into this one.

@Hydrocharged Hydrocharged merged commit 3472df6 into master Jun 25, 2020
@Hydrocharged Hydrocharged deleted the daylon/foreign-keys-3 branch June 25, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hydrocharged @zachmu