Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI Docs: Adding docs for system_variables field in config.yaml for sql-server command #7673

Merged
merged 2 commits into from Apr 1, 2024
Merged

CLI Docs: Adding docs for system_variables field in config.yaml for sql-server command #7673

merged 2 commits into from Apr 1, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Apr 1, 2024

The CLI docs for sql-server doesn't include the system_variables field available in config.yaml.

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
ab373eb ok 5937457
version total_tests
ab373eb 5937457
correctness_percentage
100.0

zachmu
zachmu approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit ebbea9a into main Apr 1, 2024
20 of 21 checks passed
@fulghum fulghum deleted the fulghum/docs branch April 1, 2024 22:05
@BrewTestBot BrewTestBot mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fulghum @coffeegoddd @zachmu