Added GROUP BY support, tests to dolt query_diff #768
Conversation
| query string | ||
| } | ||
|
|
||
| var engineTestSelectQueries = []engineTestQuery{ |
There was a problem hiding this comment.
You should be able to just get these directly from the enginetest package. They're exported. Just use the queries and ignore the expected values
There was a problem hiding this comment.
And if you're concerned that not every test query is supported (those involving typestable e.g.), just use doltHarness.SkipQueryTest to filter them.
| {query: `SELECT SUM(i) FROM mytable`}, | ||
| } | ||
|
|
||
| // runs a subset of SELECT queries from enginetest/queries.go as a sanity check |
There was a problem hiding this comment.
Any reason not to run all of them? If you're just checking that they run and produce no diff, then that should be fine, right?
Another interesting test would be to create the table, commit it, then insert the rows and verify that the "to" diff contains exactly the rows expected by the normal query in the engine test.
There was a problem hiding this comment.
that's a great idea
| @@ -262,3 +362,506 @@ func testQueryDiffer(t *testing.T, test queryDifferTest) { | |||
| assert.Nil(t, to) | |||
| assert.Equal(t, io.EOF, err) | |||
| } | |||
|
|
|||
| // subset of test data from go-mysql-server/enginetest/testdata.go:CreateSubsetTestData() | |||
| var engineTestSetup = []testCommand{ | |||
There was a problem hiding this comment.
Probably should just create these with a doltHarness. Not sure what value you get by duplicating them here.
There was a problem hiding this comment.
That method even lets you create a subset of the tables you are interested in (but creating all of them should work)
andy-wm-arthur
force-pushed
the
andy/query-diff-4
branch
2 times, most recently
from
032df45
to
a381e98
Compare
andy-wm-arthur
force-pushed
the
andy/query-diff-4
branch
from
a381e98
to
3aaa5cc
Compare
No description provided.