Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Version #7724

Merged
merged 2 commits into from Apr 10, 2024
Merged

Move Version #7724

merged 2 commits into from Apr 10, 2024

Conversation

bheni
Copy link
Contributor

@bheni bheni commented Apr 9, 2024

Moves Version into a package where it can be referenced by external code.

@bheni bheni requested a review from reltuk April 9, 2024 23:33
reltuk
reltuk approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor

@bheni DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8024adb ok 5937457
version total_tests
8024adb 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@bheni DOLT

comparing_percentages
100.000000 to 100.000000
version result total
be0c68c ok 5937457
version total_tests
be0c68c 5937457
correctness_percentage
100.0

@bheni bheni merged commit 09d74c4 into main Apr 10, 2024
20 checks passed
@bheni bheni deleted the bh/move-version branch April 10, 2024 17:27
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reltuk reltuk reltuk approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bheni @coffeegoddd @reltuk