Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foreign Keys Part 3 Episode 2 #774

Merged
merged 1 commit into from Jun 29, 2020
Merged

Foreign Keys Part 3 Episode 2 #774

merged 1 commit into from Jun 29, 2020

Conversation

Hydrocharged
Copy link
Contributor

The last bit of things to add for foreign keys!

@Hydrocharged Hydrocharged requested a review from zachmu June 29, 2020 06:20
@Hydrocharged Hydrocharged force-pushed the daylon/foreign-keys-3-ep2 branch 3 times, most recently from 76c140b to 5b8d411 Compare June 29, 2020 07:07
zachmu
zachmu approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple small comments.

go/libraries/doltcore/sqle/tables.go Outdated Show resolved Hide resolved
go/libraries/doltcore/sqle/tables.go Outdated Show resolved Hide resolved
@Hydrocharged Hydrocharged merged commit eb65425 into master Jun 29, 2020
@Hydrocharged Hydrocharged deleted the daylon/foreign-keys-3-ep2 branch June 29, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hydrocharged @zachmu