Archive Serialization and Deserialization #7799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onverter for a row due to a field's type changing.
Truth be told, this is a silly optimization. Disk reads take up more time than a binary search, by a large margin.
|
@macneale4 DOLT
|
|
@coffeegoddd DOLT
|
…ey/json-serialize
chore: use errors.New to replace fmt.Errorf with no parameters
…e session warning per column
|
@macneale4 DOLT
|
|
@coffeegoddd DOLT
|
…te_machine_struct.go Co-authored-by: Maximilian Hoffman <max@dolthub.com>
Co-authored-by: Maximilian Hoffman <max@dolthub.com>
Co-authored-by: Maximilian Hoffman <max@dolthub.com>
…te_machine_struct.go Co-authored-by: Maximilian Hoffman <max@dolthub.com>
Bug fix: Allow `dolt init` to use `--data-dir` param
…tmany go/libraries/doltcore/remotestorage,go/store/datas/pull: Implement a pipelined chunk fetcher.
reltuk
approved these changes
May 7, 2024
This should only happen if there is a bug in the writer
|
@coffeegoddd DOLT
|
|
@macneale4 DOLT
|
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't direclty change any Dolt behavior. It just lays the groundwork for archive creation and reading. Currently, no file is materialized by this code as unit tests exercise it with ByteSinks.