Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Decimal type binlog serialization #7825

Merged
merged 5 commits into from
May 6, 2024
Merged

Bug fix: Decimal type binlog serialization #7825

merged 5 commits into from
May 6, 2024

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented May 6, 2024

No description provided.

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6f0efd0 ok 5937457
version total_tests
6f0efd0 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
48414a3 ok 5937457
version total_tests
48414a3 5937457
correctness_percentage
100.0

@fulghum fulghum requested a review from jycor May 6, 2024 20:27
jycor
jycor approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@fulghum DOLT

comparing_percentages
100.000000 to 100.000000
version result total
71e1c1f ok 5937457
version total_tests
71e1c1f 5937457
correctness_percentage
100.0

@fulghum fulghum merged commit 349bbbf into main May 6, 2024
20 checks passed
@fulghum fulghum deleted the fulghum/decimal-bug-fix branch May 6, 2024 20:59
@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9b1b9b9 ok 5937457
version total_tests
9b1b9b9 5937457
correctness_percentage
100.0

@BrewTestBot BrewTestBot mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fulghum @coffeegoddd @jycor