Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minver refactor to be used by doltgres #7834

Merged
merged 3 commits into from
May 8, 2024
Merged

minver refactor to be used by doltgres #7834

merged 3 commits into from
May 8, 2024

Conversation

bheni
Copy link
Contributor

@bheni bheni commented May 8, 2024

No description provided.

@bheni bheni requested a review from zachmu May 8, 2024 19:43
zachmu
zachmu approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coffeegoddd
Copy link
Contributor

@bheni DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7584e3e ok 5937457
version total_tests
7584e3e 5937457
correctness_percentage
100.0

@bheni bheni merged commit 8dc7780 into main May 8, 2024
20 of 21 checks passed
@bheni bheni deleted the bh/minver-refactor branch May 8, 2024 21:06
@BrewTestBot BrewTestBot mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bheni @coffeegoddd @zachmu